Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RefreshView specificity on IsRefreshing #17062

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Fix RefreshView specificity on IsRefreshing #17062

merged 4 commits into from
Aug 30, 2023

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Aug 29, 2023

Description of Change

Fixes specificity on RefreshView

this is work to get #16654 fixed

Issues Fixed

Fixes #16910

@rmarinho rmarinho marked this pull request as ready for review August 30, 2023 10:49
@rmarinho rmarinho requested a review from a team as a code owner August 30, 2023 10:49
@@ -20,6 +25,164 @@ void SetupBuilder()
});
});
}


// [Fact(DisplayName = "IsRefreshing binding works")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to track this in an issue and get it working to RC 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression/8.0.0-preview.7.8842] - RefreshView does not hide spinner when IsRefreshing set to false.
3 participants